adds feature to detect multiple certificates in PEM bundles #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a PEM bundle contains multiple certificates only the first one is detected. This features adds further certificates to the JSON output: - first cert is shown as filename (#0 is omitted to stay compatible to previous outputs) - second cert is shown as filename#1 - third cert is shown as filename#2 - and so on This should solve HeinleinSupport#181
|
I am currently thinking about re-implementing the whole plugin in Python as all the string handling in Bash is getting out of hand. |
|
A disadvantage of a python solution on the agent would be the dependency to an addition module to read the certificates. AFAIK python does not include a (public) module to process x509 certificates. I'm no fan of telling people to just use When thinking about this PR I wanted to change or break as little as possible. Another refacoring step could be a refacoring that:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a PEM bundle contains multiple certificates only the first one is detected.
This features adds further certificates to the JSON output:
This should solve #181